Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improved
intersection
performance:Added a preface to
intersection
, which compares elements in the first 2 sets to create the initialresultSet
.This improves the
intersection
function significantly at scale, when comparing sets with few shared elements. Because, there is no time wasted adding elements to theresultSet
which are immediately removed, on the first comparison.The scale tests show that when taking the
intersection
of disjoint sets, we see a performance improvement of ~50 - 80%. And, somewhat surprisingly, even when taking theintersection
of equivalent sets we see a performance improvement of ~10 - 30%.[original] raw data:
[refactor] raw data:
[performance improvement] raw data: